figaro icon indicating copy to clipboard operation
figaro copied to clipboard

Published 20 hours ago • verified publisher icon laserlemon

Removing thor version requirement allows rails 6 to bundle

Open Deekor opened this issue 5 years ago • 6 comments

Quick hack. Probably not the best fix but it allows rails 6 to bundle and seems to be working properly now

Deekor avatar Jan 26 '20 19:01 Deekor

Please consider merging @laserlemon

Deekor avatar Apr 01 '20 19:04 Deekor

I just ran into this, and this gets it bundling again. Rails 6 needs thor 1.0.

danielmorrison avatar Apr 02 '20 12:04 danielmorrison

For Fsake, can someone merge this and release a new version of Figaro? Firago also conflicts with Solargraph which depends on thor version 1.0.

Rambou avatar May 01 '20 16:05 Rambou

@Rambou I've volunteered to get this merged and updated, though it'll be a few days before I have time to finish that up.

In the meantime, pointing at @Deekor's branch should get you up and running. It is what I'm doing currently.

danielmorrison avatar May 01 '20 17:05 danielmorrison

@Rambou I've volunteered to get this merged and updated, though it'll be a few days before I have time to finish that up.

In the meantime, pointing at @Deekor's branch should get you up and running. It is what I'm doing currently.

Is this still a thing? :)

Deekor avatar Feb 10 '22 21:02 Deekor

It tuned out this did happen here: https://github.com/laserlemon/figaro/commit/e932bbe3ad476dfc5ab9f465533b23bb351b09c0#diff-a28aa17ca50fb416dc54a8cda81f3873ed94d950397c5f094b0fa944939c646eR14

So gem version 1.2.0 of figaro allows higher Thor versions.

hlascelles avatar Sep 27 '22 14:09 hlascelles