Daniel Huppmann

Results 257 comments of Daniel Huppmann

Maybe this was already implemented in #397, please double-check.

Follow-up because I did some tests myself: wildcard * in variable names work, but the units are not checked. Plus there may be some difficulties here because there may be...

3 is a nice idea, but probably takes a bit more time to implement. So I suggest to implement a simple "if the variable to be validated matches the wildcard-codelist,...

Sorry for not being clear. Parsing a DataStructureDefinition for large projects is already taking quite some time, so adding yet another pydantic-validator (executed every time) might not be the smartest...

Yeah, probably option 2 makes more sense. To give some context, look at this example: https://github.com/IAMconsortium/common-definitions/blob/main/definitions/variable/energy/tag_secondary_energy_carriers_level-3.yaml There are at least three dimensions where the filter could be useful: - A...

Interesting new feature idea, but could cause issues if tags are defined in the parent and child repo.

Might be easier to add it as a property of the **CommonRegion** class (which is implicltly model-dependent). https://github.com/IAMconsortium/nomenclature/blob/30fb5b14d34da4c8905f54df4d16f2a38a24abc3/nomenclature/processor/region.py#L64 And adding a "getter" would also be helpful, currently there are only...

Thanks @strefler for chiming in, I overlooked the previous discussion. Re the commend by @merfort > ...since Carbon Management is not part of Final Energy|{Sector}, and we understand that these...

> Is there a reason that Carbon Management (or Carbon Removal) is not part of {Sector} in Final Energy|{Sector}? It's implemented in this way partly because carbon management isn't a...

That’s a great idea, and we‘d be happy to spin up a database for such reference data. As a complement, it would also be useful to implement packages or workflows...