Results 131 comments of Daniel Esik

Hi @sjorn3! Thanks for going deeper into the issue! > Unrelatedly sbt doesn't seem to recognise the profilingWarmupDuration. I seem to be getting reasonably stable outputs so I'm not too...

Without digging into the details, I'd say that any plugin that manipulates/alters implicit search info in the scalac might cause issues with integration with the scalac-profiling. But anyway, it's interesting...

@DSlug Thank you for such detailed research! I accidentally missed that the 'time in macro expand' significantly differs from the sum of the macro calls per file. That is a...

@DSlug It's been a while, but I had some time on the past weekends and tried to apply your changes to the current `master`. Unfortunately, I got worse results —...

@DSlug Yeah, if you can create a full-fledged PR, it'd be good.

Hey @acloudmovingby. I wasn't able to reproduce the issue. I followed these steps: 1. Cloned the `scalacenter/scalac-profiling` repository: `git clone [email protected]:scalacenter/scalac-profiling.git` 2. `cd` into the `external/Flamegraph` directory 3. Executed the...

Hey @mayman! Sorry for the delayed response. Let's address my two concerns separately: 1. The issue with SOF can be handled in a separate PR, as it's not being introduced...

> How about allowing two recursive calls instead of just one? It should work for the lettuce case then, right? I think so. But when it comes to recursion, it...

@fthomas ah, unfortunately, simply doing two recursive calls doesn't help: ```terminal ❯ curl -I http://github.com/lettuce-io/lettuce-core/tag/6.5.4.RELEASE HTTP/1.1 301 Moved Permanently Location: https://github.com/lettuce-io/lettuce-core/tag/6.5.4.RELEASE ❯ curl -I https://github.com/lettuce-io/lettuce-core/tag/6.5.4.RELEASE HTTP/2 404 ``` So, if...

@fthomas Alright, I applied your suggestion. Now we can abandon #3583. I'm unsure if the LOC appeared lower than it initially was though.