Daniel Esik
Daniel Esik
@diesalbla also appending to an immutable vector leads to a vector allocation, doesn't it?
I did some testing of `Logger#defaultLogBody` and got surprising results. The memory consumption of logging of the `Strict` body is way better than of `Default` (aka Streamed). I'd even say...
@diesalbla I assumed that it isn't matter. So, I've rerun the benchmark with `rechunkRandomlyWithSeed(8, 32)` and got the following ``` Benchmark (size) Mode Cnt Score Error Units LoggerBench.LoggingOfStreamedBody 1000 avgt...
@http4s/core hey team! I apologize for bothering you, I just want a little attention paid to this PR. It's not rocket science, but I really feel that exposing `Stream[F, Byte]`...
Good call, will change it, thanks!
Sorry for pushing this so hard, but can we do another review iteration? There's anxiety, this can end up with a ton of conflicts due to the forthcoming #7122...
Yeah, sorry for kvetching. It's the correct ordering. I merely tried to overtake you! 🙈
My humble opinion is that we better need to fix the scaladoc and add a new method rather than change the behaviour of that function.
I flipped through the changes, and with Ross's approval, it's good to go — no blockers from me