Daniel Esik comments

Results 131 comments of


                                            Daniel Esik

Crowdsource benchmark results

Literally full [output](https://gist.github.com/danicheg/80a6330d68e7ad032dacaf48e7d1b023).

Retire unlawful copy method of `HttpVersion`

Hmm, site generating is failing at CI. @armanbilge you might be interested in it.

Retry logs full request potentially exposing secrets

I can be wrong, but `Retry` contains redacting of the headers already. Do you pointing that we should expose the ability to redact the URI of the request?

Bikeshed `Entity.Strict`

It turns out that we changed the data type to `ByteVector` in `Entity.Strict`. Do we still want to discuss something in this issue, or can we close it? cc @armanbilge

Rewrite hashcode computation for Uri.Path

> I mean, it's a bug fix Sure, but we change the whole mechanism of `hashCode` calculating. So this might affect users somehow (in a pretty strange way though). But...

0.23 -- URI equality bug: `uri"/".addSegment("Test").addSegment("") != uri"/Test/"`; values are not equal even if they have the same `toString()`

> I'd expect `addSegment("")` to add an empty segment, so it does end in a slash @rossabaker Are you arguing that we should have this ```scala val u = uri"/".addSegment("Test").addSegment("")...

Daniel Esik