Denis Angell
Denis Angell
> I am actually working on adding a memos params (with default values) to all faucet transactions in client libraries, this PR is highly related, would you mind if I...
We should think about adding the ability to generate the index/hash for all objects especially NFTokenID.
Looks good so far I would make the PR into your own `develop` branch though or make this a draft as its not ready yet.
There are multiple examples here but it doesn't cover all of them. https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/src/utils/hashes/index.ts To create the new ones go to the [Indexes.cpp](https://github.com/XRPLF/rippled/blob/develop/src/libxrpl/protocol/Indexes.cpp#L553) file and fill in the ones that are...
> `DeliverMax` should be added to `server_definitions`, same as `DeliverMin` is there. `DeliverMax` does not exist in the binary codec therefore it should not go in the server definitions. It...
Validator Tools PR: https://github.com/ripple/validator-keys-tool/pull/60
Lots of `rippled` references in the xrpld.cfg. Should `path=/var/lib/rippled/db/nudb` be `path=/var/lib/xrpld/db/nudb`?
1. `/.rippled` in BUILD.md 2. `./rippled` in bug_report.md 3. `rippled` in gitignore 4. `rippled --unittest` in CONTRIBUTING.md
If a batch creates the object you dont have the object id... A great example is NFToken Offer and Accept in the same batch.
These functions already exist in xrpl.js however they are not feature complete, only a few of the object id hashing functions exist.