Denis Angell

Results 95 comments of Denis Angell

@scottschurr Thanks again for your update. I have fixed all of the issues. However, we are getting some weird behavior from this. Its sometimes on the tx and sometimes not....

@intelliot working on the codecov

@seelabs Yeah this is ready. I tried to test the `convertBlobsToTxResult` but was unable to build a good testcase without rewriting the function.

This seems overkill. ```python import hashlib def hash_string(k: str) -> str: return hashlib.sha512(k.encode('utf-8')).hexdigest().upper()[:64] ``` ```typescript import * as crypto from 'crypto'; function sha512Hash(k: string): string { return crypto.createHash('sha512').update(k, 'utf8').digest('hex').toUpperCase().substring(0, 64);...

We don't like this on `feature` endpoint. We believe opening up feature like this is dangerous. We have opted to move this to the ServerDefinitions.cpp file. What are your thoughts...

> @dangell7 what's the next step for this PR? Would you like to request for it to be code reviewed? Yes I would. I thought it was in the queue...

@intelliot I dropped the additional features. We can discuss them in an XLS after this PR is reviewed. "This is now ready for review."

@shawnxie999 I'm having an issue building locally so I just dumped everything and I have to nuke my computer. I'm not finished making your updates. I will make the thumbs...

@intelliot Shawn was the last one to review and he approved. I didn't see these merge conflicts and will address them but were just waiting for another reviewer...

@intelliot To my understanding all current issues and merge conflicts have been resolved.