rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Rename `rippled.cfg` to `xrpld.cfg`

Open bthomee opened this issue 1 month ago • 3 comments

High Level Overview of Change

This change renames all occurrences of rippled.cfg to xrpld.cfg. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts. For the time being it maintains support for rippled.cfg as config file, if xrpld.cfg does not exist.

Context of Change

Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).

This change essentially ensures that the config file will now be named xrpld.cfg. At the same time, everyone can keep using the config file named rippled.cfg. The plan is to remove support for rippled.cfg` in about 6 months to give everyone plenty of time to update the config file name.

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X] Refactor (non-breaking change that only restructures code)
  • [ ] Performance (increase or change in throughput and/or latency)
  • [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

bthomee avatar Dec 02 '25 19:12 bthomee

Codecov Report

:x: Patch coverage is 36.11111% with 23 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 79.1%. Comparing base (40198d9) to head (c12322c). :warning: Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/core/detail/Config.cpp 36.1% 23 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6098     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          836     836             
  Lines        71245   71249      +4     
  Branches      8322    8316      -6     
=========================================
+ Hits         56356   56358      +2     
- Misses       14889   14891      +2     
Files with missing lines Coverage Δ
include/xrpl/core/PerfLog.h 69.2% <ø> (-15.4%) :arrow_down:
src/libxrpl/nodestore/ManagerImp.cpp 73.8% <ø> (ø)
src/xrpld/app/misc/SHAMapStoreImp.h 95.8% <ø> (ø)
src/xrpld/core/Config.h 84.6% <ø> (ø)
src/xrpld/overlay/detail/OverlayImpl.cpp 32.2% <ø> (ø)
src/xrpld/core/detail/Config.cpp 74.6% <36.1%> (-0.2%) :arrow_down:

... and 3 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 02 '25 20:12 codecov[bot]

Validator Tools PR: https://github.com/ripple/validator-keys-tool/pull/60

dangell7 avatar Dec 10 '25 12:12 dangell7

Lots of rippled references in the xrpld.cfg. Should path=/var/lib/rippled/db/nudb be path=/var/lib/xrpld/db/nudb?

dangell7 avatar Dec 10 '25 12:12 dangell7

Lots of rippled references in the xrpld.cfg. Should path=/var/lib/rippled/db/nudb be path=/var/lib/xrpld/db/nudb?

Thanks for pointing this out. I adjusted the script to also rename inside the config file. There are many other files with references too, but those can be done as a separate clean up PR afterwards.

Regarding the paths, I renamed those too in the example config. I did not touch the config that someone might have stored in the repo root for testing, since they might depend on the current paths.

bthomee avatar Dec 10 '25 23:12 bthomee