Dan Finlay

Results 95 comments of Dan Finlay

Sig util is not deprecated, it represents signing behavior in MetaMask in production today. Will require investigation to identify the deviation.

Thanks for the report, we're sequencing the order of actions for ourselves now. We'll need to start by checking some metrics to confirm nobody is relying on the current behavior...

We want to have this improvement, but have been stymied by concerns that applications may be relying on the current behavior. One path forward would be to package this fix...

The provider's network is specified by the user's metamask instance, and at the moment, only user interaction can change the network. I'm interested in adding an API for requesting the...

These do seem like reasonable things to add. I removed a couple things that didn't match (regarding the old docs framework).

Hurry up! ;D

I probed around a bit today and couldn’t find any evidence that this isn’t deallocated, the element is definitely torn down by react on view change. > On Mar 2,...

Oh, interesting! I didn’t realize this was possible! > On Mar 2, 2016, at 4:45 PM, kumavis [email protected] wrote: > > element is torn down but i think three.js is...

Yeah I guess it lacks tear-down hooks in general, which would need to be passed up to the react component. That’s a good point. > On Mar 2, 2016, at...

> createViewer needs an option to offset the model or camera Oh, that's a good idea, and would really help here. Should be easy enough to do, too.