Dan Finlay

Results 95 comments of Dan Finlay

I wrote instructions on this, but my pull request was never accepted: https://github.com/flyswatter/mws-js

My pull request did indeed explain this, as it was a README update. "Feeds" is not defined because it is not imported into mws.js by default. Go ahead and dig...

Oh, I hadn't even seen that branch. I see the closure you mean, but don't have time to muck through it myself. Good luck getting a response here! Out of...

Yeah this problem was surprisingly easy to get around, and looks like the latest version makes it even easier. Basically the README is wrong. The basic example should look like...

Oh wow, that's an interesting catch! I'm actually very surprised that all the tests passed considering this variance. I'm going to need to do some extra investigation here. Thanks for...

Oh, it was just a commented suggested code. So we had generated some bad docs but not bad code. Relieving. I'm hoping to add a proper entry-point generator also on...

Would you mind adding a test to prove the issue and that the change fixes it?

That seems to have done it, thanks! Homebrew worked great as usual. If only it were on all systems, you could add `scripts{ "preinstall": 'echo "brew install google-sparsehash"'` to the...

“See all” doesn’t quite capture “we think this other stuff isn’t as dangerous”, imo.

Looks like this should be good to merge?