Fox Mascot needs teardown

[kumavis]

make sure we aren't rendering even when he is off screen. all your battery gone!

[danfinlay]

I probed around a bit today and couldn’t find any evidence that this isn’t deallocated, the element is definitely torn down by react on view change.

On Mar 2, 2016, at 3:25 PM, kumavis [email protected] wrote:

make sure we aren't rendering even when he is off screen. all your battery gone!

— Reply to this email directly or view it on GitHub https://github.com/MetaMask/metamask-ui/issues/2.

[kumavis]

element is torn down but i think three.js is still rendering to an off-dom element

[danfinlay]

Oh, interesting! I didn’t realize this was possible!

On Mar 2, 2016, at 4:45 PM, kumavis [email protected] wrote:

element is torn down but i think three.js is still rendering to an off-dom element

— Reply to this email directly or view it on GitHub https://github.com/MetaMask/metamask-ui/issues/2#issuecomment-191512612.

[kumavis]

also i think the mouse tracking is still going on

[kumavis]

im more concerned with the rendering though

[danfinlay]

Yeah I guess it lacks tear-down hooks in general, which would need to be passed up to the react component. That’s a good point.

On Mar 2, 2016, at 4:46 PM, kumavis [email protected] wrote:

also i think the mouse tracking is still going on

— Reply to this email directly or view it on GitHub https://github.com/MetaMask/metamask-ui/issues/2#issuecomment-191512720.