Dan Finlay

Results 95 comments of Dan Finlay

I guess I need to wait to be assigned an EIP number before I can fix the bot's complaints.

Changes accepted. Thanks, @MicahZoltu.

Any ideas which part of this module aren't browserfiable, that a contributor might be able to pitch in on those? On Feb 15, 2014, at 4:20 PM, Mark Schmale [email protected]...

> Look, the deprecated sign does this in a better way: Deprecated sign only shows hex ;) > I'm happy to make a fix. I think your proposed solution is...

That’s awesome, and demonstrates you’ve already played with what I’d thought would be the hardest part of this idea! I think there is a pretty big difference though, between the...

Hi, thanks for the review! > Same concept as GSN in the OZ contracts, correct? That's right. They should be completely compatible. I'll verify as much and get back here....

Ok, I've made a few changes: - [x] Moved the `_msgSender()` implementations into a single util file. - [x] Copied the better-documented version of the `_msgSender()` that I linked to...

Oh that's interesting, does the multicall functinality rely on similarly appending to tx.data?

Specifically, I want to get a signed transaction after it was submitted to ganache's unlocked account mode.