Dan Davison

Results 601 comments of Dan Davison

I'm wondering whether the problem (`shell: /bin/bash -e {0}`) is that `&&` is not being parsed correctly (it's in shell code in YAML). But we need to ensure that the...

Thanks @MarcoIeni. So looks like bash is the default on non-Windows builds, and by default they use `set -e` semantics, so what you had in the CI should be perfectly...

Hi @nickelc I trust your changes but would you mind spelling out for me exactly what problem this change is solving?

How will I know when to update the MSRV?

It might well be my lack of familiarity with standard Rust practices but my worry is that this is more moving parts to maintain. When I'm in doubt I sometimes...

- [x] Prevent deletion of the first character of "Index: " lines (it's being deleted because in normal git output it would be a `+/-` indicator, which delta does not...

> Hi! I'm a subversion user and would love to use this feature; can you use help on this PR? Hi @Minnozz, sorry I forgot to reply to this. Absolutely,...

Inactive, could always revisit.

Thanks! I haven't spent much time with this, but `diff=rust` isn't always an improvement is it? E.g. here (before on the left, after on the right): The current version helpfully...