Dan Davison

Results 601 comments of Dan Davison

https://github.com/temporalio/sdk-core/pull/776 has been merged, and so this is unblocked. In `sdk-python` and `sdk-dotnet` that PR allows the https://github.com/temporalio/features/issues/481 requirement to be solved relatively easily, by changing lang so that they...

Hi @LunarLambda, thanks for working on this. I'm aware that there have been several requests for control over blank lines in output. Can we make your new option opt-in (i.e....

@DarkPark @baryluk what's the recommended course of action here? I saw you made this diagram: https://github.com/dandavison/delta/issues/1248#issuecomment-1336260157 ![image](https://user-images.githubusercontent.com/110322/205462578-92e6d07e-22ab-4c9c-ab4d-c90ca04b4ce3.png )

> A possible way to address this would be to build delta on a debian image instead of ubuntu-latest (I think) so the dynamic reference uses an older version of...

Superficial research: there's a similar bat issue https://github.com/sharkdp/bat/issues/2106 with possibly applicable fix https://github.com/sharkdp/bat/pull/2194

Hi @injust, I believe we initially encouraged auto-detection in the docs, and I subsequently back-pedalled a bit: https://github.com/dandavison/delta/commit/1fb6f99ec498150f552c1c8b5440152c0c2aade7 I didn't do a good job of linking that commit to an...

Hi @adamchainz, thanks, although #237 was a big advance (being able to leave `navigate` activated and start using it without thinking), I've also been wanting to improve things so that...

Thanks @flrgh! I believe this should be an easy fix to make. We use the Rust bindings to libgit2, and they have https://docs.rs/git2/latest/git2/struct.Config.html#method.find_xdg This is one/the relevant section of delta...

Hi @egrieco, can you post an example diff / hunk that repros the problem? There are extensive tests in delta for the 1-1 correspendence and I believe that other than...

I like the direction of this PR, but would like to work on the wording a bit before merging. > @dandavison - any thoughts/suggestions on API docs for explaining exceptions...