Dan Davison

Results 601 comments of Dan Davison

Hi @kevinhwang91, yes you're right, the background colors aren't making much sense currently :/ Thanks for this! I'll have another think about this and modify the behavior (without changing the...

Hi @bew I'd be happy for someone to make this possible. I don't have time to look into it currently unfortunately. IIRC the current configuration interface doesn't quite make this...

@danwilliams yes go for it, I haven't been able to get to it. Could be helpful to post a design proposal (i.e. any modified meanings of existing options plus any...

Closed by https://github.com/temporalio/temporal/pull/5848, tests added https://github.com/temporalio/temporal/pull/5854

@keith-hall would you mind explaining why bat doesn't suffer from this problem? Delta uses bat's highlighting assets and is suffering from it.

Hi @jumper047, yes I sympathise with this. I'd be happy to review a PR.

Thanks! I'm running your commit locally. I might be slightly slow to review and merge due to day job.

> If buffer lines exceeded this value, then default magit highlighting used instead of delta I'm not seeing any color when it disables delta. Do you see the usual magit...

Hi @Atemu, yes I see you're right. It's implemented as an Emacs minor mode and so in theory `M-x magit-delta-mode` should toggle it. But I see that it becomes reactivated....