Dan Davison

Results 601 comments of Dan Davison

Hi @nickurak @matttbe ultimately the problem here is that traditional grep output is not unambiguously parseable, due to the use of characters as delimiters which might also occur in file...

@rossburton is it possible for you to use `rg --json` instead? The delta manual contains an entry addressing this: > If you don't need special features of git grep, then...

Hi @th1000s, nice to see you. I'm getting a crash on this branch with the diff below, but not when piping explicitly into delta -- only when allowing git to...

Hi @th1000s, sorry to be slow here. You're right -- it was dependent on gitconfig. The crash can be reproduced by setting ``` [diff] colorMovedWS = allow-indentation-change ``` and viewing...

Sorry Marco, we'll leave you in peace, unless we have problems with CI / CD...! (Marco is the architect of delta CI/CD and advanced the project enormously by single-handedly [moving](https://github.com/dandavison/delta/pull/417)...

> Is this worth it? I am finding this hard to answer: I never work in repos with tabs, except for in Makefiles, and there they are always at the...

> I see, raw ansi codes produced by colorMovedWS or colorMoved cause this I'm sorry @th1000s -- I think that you have fixed this bug (right?), but when I read...

Build is currently failing to compile `bitvec` when running `cargo-tarpaulin`. Looks like it may be related to the `nom` dependency: https://github.com/xd009642/tarpaulin/issues/756 ``` Compiling bitvec v0.19.5 error: Broken pipe (os error...

> I suspect this can be written as: > > ```rust > .map(|(k, v)| (k.into_owned(), v.map(Cow::into_owned).unwrap_or_default())) > ``` Thanks! I believe you're right. 7d4c3c8b26d39a30fec34058492b29aa3eccce46. I guess if this were 100%...

Hi @alexmurray, I'm sorry this got forgotten. Other than merging this PR, what else would have to be done?