Dan Davison

Results 601 comments of Dan Davison

Sorry for not giving this much attention. It's not because I'm unaffected -- I use magit-delta daily and I encounter performance issues too (moving point in `magit-status-mode` slows to a...

Thanks a lot @mpereira. So here's the thing. I see that `magit-git-wash` dominates the profile timing with or without `magit-delta`. But I have not been able to reproduce the finding...

Here's perhaps a slightly better way to time this: ``` curl -sOL https://raw.githubusercontent.com/dandavison/magit-delta/master/bin/time-magit-status chmod +x time-magit-status ``` Then in a git repo with a large outstanding diff, either ``` USE_MAGIT_DELTA=0...

Thanks a lot for doing that @naistran. I tried it on someone else's machine last night (and a smaller diff) and also saw slower times for `magit-delta`. I'm not sure...

Thanks @willbush, I ran your commands and can reproduce the slower timing with magit-delta. Here's some quick profiling results: **with magit-delta** **without magit-delta** Here's one of the key magit functions...

Hi @tarsius, do you have a moment to advise on the performance issue we're discussing here, and maybe glance at the profiling output above (https://github.com/dandavison/magit-delta/issues/9#issuecomment-932664530)? The tentative conclusion I've reached...

Thanks a lot @tarsius. Supposing that's the case, do you have any hunches or ideas about ways to improve the performance? For example, one thing that's coming to my mind...

Hi @junyi-hou, thanks for this. I'm pretty sure it's possible! Below are some implementation notes for me or anyone else who wants to take this on: This didn't fall naturally...

@aaronjensen awesome work! Magic: So, make this the new default with the old behavior optional? Do you feel like making a PR? (I think people will largely appreciate the breaking...

OK, for the colors does `delta --show-config` help?