Dan Davison

Results 601 comments of Dan Davison

Also, just to check -- is delta working correctly outside magit? Is it just staging individual hunks that is problematic, or are there any other problems when using magit-delta?

@vermiculus this problem seems to be specific to your environment. What would be really helpful is if you could capture the patch that is being sent to git: > error:...

Hi @g5pw, that's right: `line-numbers` cannot be used with `magit-delta` since it creates invalid patches. The simplest approach is to make `magit-delta` independent of your command-line delta settings using: ```...

Just a note: for Mac users there's no conflict here: copy is `Cmd-c` and the traditional emacs "execute & dismiss" operation used widely in e.g. magit and org-mode is `Ctrl-c...

Yes, there's a little bit of a mess here that needs sorting out. TL;DR: `line-numbers` cannot be used with magit-delta (see below). If you want to be free to use...

Actually, I think there's a better solution involving using delta "features". Try setting your `magit-delta-delta-args` something like this ```emacs-lisp (setq magit-delta-delta-args '("--24-bit-color" "always" "--features" "magit-delta" "--color-only")) ``` Then magit-delta will...

Hi @wyuenho, instead of setting the `line-numbers` boolean directly in the main `delta` stanza, can you try activating it via its feature: ```gitconfig [delta] features = line-numbers [delta "magit-delta"] line-numbers...

> Does that means I can only really have one set of configs anyway? No, pretty much anything is achievable I think -- I'd be happy to try to provide...

> What's the relationship between [delta], [delta "feature"] and delta's defaults? Does this help? ```gitconfig [delta] # settings here will always be applied unless the user supplies --no-gitconfig on the...

Ah I'm sorry, I should have linked this issue: https://github.com/dandavison/delta/issues/446 > the same key in a feature section does not override the main section, because anything in the main section...