Dan Davison

Results 601 comments of Dan Davison

So my suggestion ```gitconfig [delta] features = line-numbers [delta "magit-delta"] line-numbers = false ``` is a workaround for that bug. What you did definitely _should_ have worked.

Thanks @kahole! I can definitely see that the native diff viewer may be the best way forwards (modulo the fact that it's not currently exposed in the API). So no...

I also got here because I would like background colors on the `@@` lines to make them stand out more, and was searching for existing issues. I know there's no...

Hi @CSRaghunandan, what version of xterm-color do you have installed? Can you confirm that disabling magit-delta with `M-x magit-delta-mode` makes this problem go away? Does this always happen for you,...

Hi @Macavirus, sorry to be slow here. I don't think it does: the overhead of calling delta and converting the ANSI escape sequences to emacs text properties is, I believe,...

> I find that up/down arrow (`magit-prev-line` /`magit-next-line`) in magit diff buffers become very slow sometimes but I still haven't worked out why. (I do need to double-check that still...

> What does the profiler show? Good question. I think I looked at this before, but I'll try to do it again when it next happens.

OK it happened again. It seems to be saying that the time is spent in `line-move-visual`. ``` - magit-next-line 35 7% - line-move 35 7% line-move-visual 33 6% ``` (The...

@braineo how is performance in the situation you describe when using magit without magit-delta?

Thanks, interesting! Is it a public repo? If so a commit / any other instructions to reproduce would be great.