Damien L-G

Results 491 comments of Damien L-G

So this PR is handling the double underscore right?

> The bugprone-reserved-identifiers check seems to catch reserved patterns reliably (this is my first time using clang-tidy). It may make sense to add it as an automatic check. I expect...

> It does catch them, this PR just does one kind of change at a time 😄 But with your adding the check in the ClangTidy configuration file we would...

Could you please report the kernel launch parameters used internally by Kokkos and by Thrust?

Looks like the build on the spack gltlab was significantly faster but I did not see improvement on the Jenkins build

> I don't quite get the argument that it forces to guard against the version. Doesn't it always if I deprecate/remove/introduce-something new? Because there is no overlap of versions with...

Thanks for sharing your solution. There is currently no consensus to change the deprecation vehicle. I will keep this issue open a bit longer to give an opportunity to others...

Need to fix: * [ ] `isnormal` is not provided by CUDA * [ ] half types

Just to be clear, Daniel are you suggesting that you are welcoming a PR from Maarten or are you working on this? Whoever does, please self assign this issue to...

It does report the Impl::SerialInternal::singleton() along with more reports that we need to look into. https://github.com/kokkos/kokkos/actions/runs/14735859878/job/41362989248?pr=8043#step:12:109