Damien L-G

Results 491 comments of Damien L-G

We will need to fix Kokkos Kernels as well as a number of packages in Trilinos (as far as I can tell, ifpack2, intrepid2, sacado, shylu, stokhos) Use `git grep...

We could look into writing a Clang-Tidy check with a FixIt to automatically replace these.

> > This has been discussed in the past and we had agreed that the status quo was better than wildly oversubscribing nodes with the default setting. > > We...

How do we go about making sure that this stays in sync? Did you consider whether we could/should have builds with IWYU in the CI?

Does Spack support appending user-specified cmake flags in the configuration step?

> Is it possible to catch the space used during view allocations? Are deep copies and creating mirror views already captured by the existing patch? Not possible without changes in...

I need to do something like https://github.com/kokkos/kokkos/pull/7432/commits/7e0fc5e296b778e06d49ea40810aaa2f6b108359#diff-8b14e0420249c1698d04b2eb3998f490bdd7ec0fa2c24eb02572e71405997402R1627-R1631 ?

I looks like it is used in Sacado... ``` packages/sacado/src/Sacado_DynamicArrayTraits.cpp:15: const Kokkos::MemoryPool* global_sacado_openmp_memory_pool = 0; packages/sacado/src/Sacado_DynamicArrayTraits.cpp:23: const Kokkos::MemoryPool* global_sacado_cuda_memory_pool_host = 0; packages/sacado/src/Sacado_DynamicArrayTraits.cpp:24: const Kokkos::MemoryPool* global_sacado_cuda_memory_pool_device = 0; packages/sacado/src/Sacado_DynamicArrayTraits.cpp:26: __device__ const...

Christian suggested to deprecate `atomic_{inc, dec}rement` and also `atomic_compare_exchange_strong`

Thoughts on deprecating the `nand` op? It is not like we do anything special, it is literally a "not" `and`. **edit:** they are never used in Trilinos