Damien L-G

Results 491 comments of Damien L-G

`KOKKOS_DISABLE_WARNINGS=ON` on is not valid Chose from `1`, `TRUE`, `YES` (case insensitive)

https://github.com/kokkos/kokkos/blob/0ef409bab190cdae9417bff34f7cf5c90048f227/core/src/impl/Kokkos_Command_Line_Parsing.cpp#L60-L64

You can open another issue if you want to make the case that it should be valid.

We are aware that it is a breaking change. We discussed it both on the PR and at the developer meeting.

The gist of it was that boolean environment variables (namely `KOKKOS_DISABLE_WARNINGS` and `KOKKOS_TUNE_INTERNALS`) had different parsing rules before #5221 . For instance `KOKKOS_TUNE_INTERNALS=YES` was interpreted as `false`. No matter what...

The potential issue with your suggestion is we lose the `find_path` call to locate the `dlfcn.h` header and it is not added to the list of include directories.

Do you mind trying 9beba321593b97645b0bda866a8e84c5cc9fc050 ?

What about 7ffb61a105ae513a66ad95a9e9c525411900b8d1

Do you see the same issue with the `develop` branch?