Damien L-G

Results 491 comments of Damien L-G

@derekmauro this is still an issue on our side. Would you please review?

> Let's see if someone complains. In the end, `reduction_identity` should only be relevant if people call `parallel_reduce` but, of course, they might just have included this header for specializing...

> If this breaks too many projects, we could, of course, include `ReductionIdentity.hpp` in `Kokkos_NumericTraits.hpp` again. I would only consider it if guarded with `KOKKOS_ENABLE_DEPRECATED_CODE_4`

In Trilinos https://github.com/trilinos/Trilinos/blob/597f531b9be215f69c06b58c97bbd6a2bd0ccddf/packages/stokhos/src/sacado/kokkos/pce/Sacado_UQ_PCE.hpp#L1315-L1336 https://github.com/trilinos/Trilinos/blob/597f531b9be215f69c06b58c97bbd6a2bd0ccddf/packages/stokhos/src/sacado/kokkos/vector/Sacado_MP_Vector.hpp#L2063-L2084 would need to be updated. That's all I could find.

> I think it's a good change but we should deprecate the current code since we know it will break user code. OK as a compromise what if I include...

Conflicts with #5378 I assume you want to rebase after #5378 gets merged Please advise

@matt-stack would you be able to assist with this issue?