Damien L-G
Damien L-G
I think we should keep an example that shows how both indexes can be used.
Please rebase or create a new PR to tackle the "unified memory" part
Deferring to Christian and Conrad.
@rgayatri23 Make sure you add this to the change log
Retest this please
(SYCL build passed)
> As far as I can tell these warnings are spurious. This pull request proposes two different solutions to suppress this warning: > > 1. Guard the offending code with...
> I just enabled compiler warnings and tests and the compiler reports (using Homebrew on MacOS X) Did you try to reproduce on the compiler explorer with Kokkos 4.1?
Also do we understand why we can't reproduce it on the compiler explorer nor in the CI build? (not saying we are not interested in fixing, just trying to understand...
> Did you consider changing the arguments to `std::integral`? I think it would be more readable It does not really work because we need to do +1