Damien L-G comments

Results 492 comments of


                                            Damien L-G

Remove unnecessary work-around for HIP

We need to look at the assembly, whether the loads are vectorized.

Add example distributed tree k-nearest neighbors search

Can't approve obviously but fine by me

Build GPU code only for arch enabled in Kokkos with HIP

Closing since this is being addressed in Kokkos from release 4.3 We might want to document somewhere in the build instructions the recommendation to configure with `-DGPU_TARGETS=gfx90a` until then if...

Provide `round_up` and `round_down` for converting double to float

`Kokkos::nextafter()` is available since Kokkos 3.7 Did you want to keep this issue open to track possibly investigating controlling how fp rounding is done? If so, maybe update the title...

Deprecate `CudaUVMSpace::available()`

Done

Nightly build failures with intel/19, "missing return statement at end of non-void function"

Please confirm what build and what warning.

Suppress warning: function declared with "noreturn" does return for CUDA and Debug mode

Correct.

Suppress warning: function declared with "noreturn" does return for CUDA and Debug mode

Keeping the warnings to remind you to upgrade to 4.0 when he gets out

openmp.team_broadcast_long unit test segfaults with gcc/10.2.0

You should not need the `-Wno-deprecated-declarations` flag since #6999 and #7016

openmp.team_broadcast_long unit test segfaults with gcc/10.2.0

Did Nathan say it was ok to close?