Damien L-G comments

Results 491 comments of


                                            Damien L-G

[WIP] Add m_stride to layout to support propagation of Padding

This PR still have Work In Progress in the title line. Is that an oversight? Is it ready for review?

[WIP] Add m_stride to layout to support propagation of Padding

@janciesko is this still a work in progress (title line is prefixed with [WIP]) Also the test you added does not pass ``` [ RUN ] openmp.view_with_padding_copying /__w/kokkos/kokkos/core/unit_test/TestViewPadding.hpp:587: Failure Value...

Test Legion use case

I just realize the compile test is not being removed any more. Is it intentional? I am fine with the removal.

SYCL RangePolicy: manually specify workgroup size through chunk size

Title line is misleading because it only applies to parallel_for, not parallel_reduce. Please comment whether this can/should be implemented for other parallel constructs with a RangePolicy.

Stokhos: support for custom types in `Sacado::MP::Vector`

> Unfortunately, we cannot use Kokkos::OPER as you suggest. Indeed, the code must support double, std::complex and Kokkos::complex. I see. It is a bit awkward though because it is not...

Stokhos: support for custom types in `Sacado::MP::Vector`

> The changes look good to me. @dalg24 are your concerns addressed? Yes this works. (I do not have permissions to mark conversations as resolved.)

Dispatch Kokkos::sort(Kokkos::View) to ROCm Thrust

Test this please

Dispatch Kokkos::sort(Kokkos::View) to ROCm Thrust

OK to test

Add readability-implicit-bool-conversion

This one is wildly out of date and not being worked on currently. Closing.

Current status of mathematical functions

> Are you planning to add the reciprocal functions available in Cuda? Should be easy to provide a fallback if a native version is not available. No ongoing plan but...