Danil Alexeev

Results 283 comments of Danil Alexeev

![](https://github.com/godotengine/godot/assets/47700418/d9520e02-ebb2-4de3-93a5-a57507ad99ab) ![](https://github.com/godotengine/godot/assets/47700418/2836e7e1-dbbc-43d3-af7c-b2d836275774)

After investigating the profiler data, I tentatively think we should try caching `Tree::get_column_minimum_width()`. I will try to do this tomorrow.

> How I can get this fix or wait untill 4.2.devx version? I opened PR #79325 which you can test. Yes, this is a change for 4.2, but if the...

`TOOL_BUTTON` as well as `GROUP` should be a "pseudo member" and must not shadow real members in `members_indices`, see #78254. In property list the names should be different too, I...

> Reviving this, do we want to move forward? I wonder what's the solution for invalid default values (e.g. when `0` is outside the range or does not belong to...

> large number are wrongly formatted, if they are not formatted they do not change and if they are formatted every `_` gets removed. The exact formatting of the literals...

@aaronfranke You are probably right, although both `class_name` and `extends` are optional (if `extends` is omitted, the class extends `RefCounted`).

> As this is a HUGE PR, I suggest to merge it sooner than later. If there are no regressions found in existing features (what about doc comments?), then I...

What about points 3 and 4 in [the comment](https://github.com/godotengine/godot/pull/76211#issuecomment-1519490403)? I can test this PR again when you confirm you are done.

`[example_class.new()]` is a non-constant expression, so export won't work (at least without `@tool`). See #71091. But it looks like inner classes are not supported, the "Cannot get class 'example_class'." error...