David Luecke

Results 292 comments of David Luecke

Good point, that would be a fairly easy non-breaking change. I'm still a bit on the fence about what to do with the adapters in general. In most projects I'm...

Thank you! I'll look into why the tests aren't passing today.

The update is probably still not possible without introducing a breaking change (as the breaking tests in #3532 showed before the logs expired). I recommend installing your own Typebox dependency...

`getValidator` will work but `querySyntax` is where the compatibility issue is happening. There was an attempt for compatibility in https://github.com/feathersjs/feathers/commit/962bd87217212320b1a68f6556a16b8a6b8f757c - I haven't tested it with newer versions of Typebox.

The commit was merged but reverted later since it caused the issue described here. I put up a new PR to the latest TypeBox in https://github.com/feathersjs/feathers/pull/3565 might be worth iterating...

You can update the test configuration to your needs - e.g. by removing the `--exit`.

Is there a way to confirm this. Aside from [the compilation failing](https://github.com/feathersjs/feathers/actions/runs/13797915130/job/39138659083?pr=3574#step:8:1077) I just tested the existing setup with Google and it worked as expected.

It looks like you are using MongoDB aggregation in your `users` service. By default the strategy calls `userService.patch()`. I'd recommend first making sure that the `patch` method returns the format...

Closing this since I think it is related to the MongoDB aggregation and works as intended in the default case. Appreciate the PR though!

Probably related to https://github.com/feathersjs/feathers/issues/3412