David Luecke
David Luecke
Thanks for digging into that. I'm assuming this would be reproducible by adding a custom method to a client service and trying to add hooks to it?
Would this be enough to create a minimal example to reproduce? I wonder if this is happening because of how custom methods are initialised in https://github.com/feathersjs/feathers/blob/dove/packages/rest-client/src/base.ts#L70-L96
The TypeBox workbench is neat. But yes, constructing the actual query you want to allow with basic TypeBox instead of having it try to somehow infer it would be my...
This has been done now in https://github.com/feathersjs/feathers/pull/3612 and will be released with v6 since there are breaking changes in initializing the query syntax and the supported operators.
Thank you for the pull request. It looks like the types require a parameter which is why the compile step fails. What does the current failure look like?
`{ resolveConfig: await prettier.resolveConfigFile(ctx.cwd) }` sounds like the more robust solution to me?
https://github.com/feathersjs/feathers/pull/3529
I think this makes sense, however, the tests are failing with a TypeScript error at https://github.com/feathersjs/feathers/actions/runs/10403476191/job/29583715944?pr=3525#step:8:698
The suggested fix has been published as v3.1.0
At least transport commons needs to stay in to extend the types properly. We have to set up CI for this again to make sure all tests are passing.