David Luecke

Results 245 comments of David Luecke

I've been seein the same error in the latest version in https://github.com/feathersjs/feathers/tree/dove/packages/schema. The smallest example I could come up with to reproduce looks like this: ```ts class Test { readonly...

The problem with unregistering services isn't Socket.io (the legacy event handlers will be removed in the next version anyway), it's that Express does not allow to unregister middleware. Overwriting a...

Although it is not documented you should be able to use the `parseAuthentication` middleware again on the route you want to override the service for: ```js app.configure(express.rest()); // ... app.use('/v1/*',...

Totally. I noticed that issue and then forgot about adding it in the PR. I think we need an adapter service interface in core.

This will be closed in the next prerelease via https://github.com/feathersjs/feathers/pull/2750

In v5 we removed all our custom socket timeout handling and just defer directly to Socket.io. So it might be worth testing this with the latest prerelease and see what...

Yes, the return value should be `null`. It's tested at https://github.com/feathersjs/feathers/blob/master/packages/express/test/rest.test.js#L519 (service at https://github.com/feathersjs/feathers/blob/master/packages/express/test/rest.test.js#L467). Not entirely sure where the best place for it would be in the docs.

Hm... this is a good point, I'm wondering if the CLI should do more here and ask for the origin urls.

Do you have an example to reproduce? I just tried throwing a different kind of error in the [feathers-chat](https://github.com/feathersjs/feathers-chat) and the frontend catches it as expected.

By default the hash is always being removed but it might clash with whatever routing library you are using. You might be able to work around this by [customizing the...