David Luecke

Results 292 comments of David Luecke

Probably not unless someone who is using this module has a chance to look into it. Something that might also make more sense is to look at a custom authentication...

This looks good. We could update this module to use that?

If you are going with a normal setup, the expectation is that the authentication strategy looks up or creates a new user on the `users` service and returns that: ```js...

This should basically be the next version of this module, just need to figure out a good way to test it in CI. I always found LDAP a little convoluted...

Is there a way to spin up a super simple standalone LDAP server in a GitHub action?

This should now be working using the new [client package](https://feathersjs.com/guides/cli/client.html). #235 has a React chat example that uses it.

Excellent, thank you for putting this together!

For adapter services all their service methods can be called without hooks by using their underscored (`._get`, `_.find` etc.) methods (see https://feathersjs.com/api/databases/common.html#methods-without-hooks)

This should be as trivial as adding ``` js var normalizer = configuration.normalizer || function (filename) { var relative = configuration.baseUrl || path.dirname(configuration.out); return path.relative(relative, filename); }; ``` in https://github.com/daffl/can-compile/blob/master/lib/index.js#L12....

Here is a question, what do the params hooks do differently than something like this? ```ts async (context) => { const { myParam, ...query } = context.params.query || {} context.params...