David Luecke comments

Results 292 comments of


                                            David Luecke

chore(docs): New Docs and Website

Closing this PR since the new docs are available now at https://dove.feathersjs.com. We'll keep the branch around in case there is anything else we still need from it.

Create Service API mutates function arguments

I'm going to close this since in current Feathers all built-ins (hooks, dispatchers, database adapters etc.) have been made sure to no longer mutate any existing objects. It is still...

[feathers-dove] - How to perform transactions?

This is now documented in https://feathersjs.com/api/databases/knex.html#transactions

protect()-hook does not hide the protected field in realtime events when patching multiple records

This has been fixed via https://github.com/feathersjs/feathers/pull/3073 and published in v4.5.16

Calls to feathers services with HEAD method are throwing an error since v5.x.

Are you using Express or Koa? What did it return before?

refactor: reduce usage of lodash

Great, I've been meaning to look into this so thank you for doing that.

is there any update on Adding the Support of feathers v5 for this library?

Someone is always welcome to contribute this but since [the future of ObjectionJS is generally uncertain](https://github.com/Vincit/objection.js/issues/2335) there are currently no plans for this.

Reported app.channel(channel).connections incorrect with multiple instances of feathers-sync

Feathers tries to provide as stateless of an architecture as possible so while there are persistent channel connections, they should only be used to distribute them into channels, not to...

Reported app.channel(channel).connections incorrect with multiple instances of feathers-sync

Connections are object references to the actual sockets on an instance so they can't be saved to a persistent storage. Storing all connected clients by their id in a key-value...

Converting circular structure to JSON

If you payload contains circular JSON you can use a [custom serializer](https://github.com/feathersjs-ecosystem/feathers-sync#custom-serializer--deserializer)