David Luecke comments

Results 292 comments of


                                            David Luecke

OAuth with OKTA work but I receive a ECONNREFUSED 127.0.0.1:80 just after the token and finally auth fail

This should also be working now with the new v5 oAuth

Authentication Client caching BadRequest responses from create

This was indeed a bug and will be fixed with #2892

Authentication Client doesn't remove URL hash when JWT is already stored

I tested this with the latest `.pre.34` which has a number of authentication client improvements and I think this should be solved now.

[Suggestion] Filtering resolver properties

So after a bit more discussion on Discord today and based on #2900 think that this can all be addressed now very flexibly with a `$select` query resolver. For example,...

[Suggestion] Filtering resolver properties

I believe this would still be possible, although it'd have to be on the schema/service level since we need to know about all the properties (easier introspection is definitely something...

Is socket connection coupled with JWT token expiry?

I just realised that while addressing https://github.com/feathersjs/feathers/issues/2754 in the PR at https://github.com/feathersjs/feathers/pull/2896 I think this also applies to this issue. If a token expires the client socket will now be...

adapter-commons/filter-query.ts:cleanQuery whitelist test

So over the last little while we realised that all the query sanitisation is just a complicated and convoluted way of doing query schema validation which is exactly what we'd...

Feathers auth client does not treat non-401 failures as failures

I believe #2892 should fix this issue as well.

feat: Add `exposed` property to hook context

I'm going to close this one since it has now diverged quite a bit and I think this can also be handled by checking for `params.provider`.

feat: Add `exposed` property to hook context

I think then we should add it in https://github.com/feathersjs/hooks as a Symbol property you can read via `context[RETURNED]` (or `EXPOSED` or `PUBLIC`). From a Feathers perspective currently, I believe what...