Damien Elmes

Results 241 comments of Damien Elmes

The goal is to prevent users from accidentally having all their cards answered when they switch away to a different window / start editing the current card, etc.

That would result in auto advance resuming when the user switches back to the app, which I think some users wouldn't appreciate. It also doesn't help you, if your use...

I'm confused by why we're using a different query for ascending and descending order - could you help me understand the thinking here?

Thank you for your research! If removing some of the existing styling would improve appearance without causing regressions in other areas, I'm all for it.

This is impressive work llama! I'll need a bit more time to review the current code properly, but I wanted to give you some quick feedback to unblock you. -...

I probably won't have a chance to circle back to this until late this week/early next week :-( If you're blocked on anything, please let me know and I'll try...

Apologies for the delay, and thank you to everyone who's contributed. > assuming card.set_memory_state is much slower than everything else. > So, we might get a speedup by retrieving and...

> It would still be nice for the PR description to describe the current state of things, and what sort of improvement this has made. Still would appreciate some actual...

That's an impressive improvement - well done to you both. I've looked through the code briefly and it looks well written. My only remaining issue is with the smoke test...