Damien Elmes

Results 241 comments of Damien Elmes

One-off flakes in the past week: com.ichi2.anki.tests.ContentProviderTest > testBuryCard[1][test(AVD) - 10] FAILED com.ichi2.anki.tests.LayoutValidationTest > ensureLayout[fragment_anki_stats_overview][test(AVD) - 10] FAILED com.ichi2.anki.tests.ContentProviderTest > testInsertTemplate[0][test(AVD) - 10] FAILED Upon re-running the connected tests a...

Can't reproduce, but does this help? Changed the test to exercise the non-null case, and removed the mutex in the process, as withCol should enforce single execution. ```diff diff --git...

Whoops, I changed withCol to withOpenColOrNull at the last minute, so the assert should now check for null as well. Looks like I got the arg order on the assert...

Is there a way to get the logcat output from the failing test?

In my latest PR CardBrowserTest > checkDisplayOrderPersistence FAILED happened on both Ubuntu and Windows; retrying now.

Failed again. Will push a probable fix.

- The spinning is the same on the desktop when you hover over the option - I believe Henrik intended it to be that way, though the behaviour on mobile...

Appears to be possible: https://stackoverflow.com/questions/2726377/how-to-handle-a-webview-confirm-dialog

For some background on why such a change is recommended, see https://github.com/ankidroid/Anki-Android/pull/11849 Because withCol is a coroutine, it needs to be called in a coroutine context - either inside another...

Sadly the current API passes a reference to the collection into each Card/Note object, meaning that calls to things like card.note() result in a DB query. To ensure this is...