Damien Elmes
Damien Elmes
I'd rather we keep things simple and avoid the need to persist the setting. I don't think it's a big ask to the few users using this to tap a...
I am in favour of both the taps + warning (as I'd have thought my mention of a more forceful warning above would imply!). But it's a no to making...
Reviewing the current state of the PR: - Still think an inline Warning would be less bothersome for the niche users - Unfortunately, the taps are not working so well...
Sorry it's taken so long to circle back to this. Gave the latest code a try: - Triple clicking on the numbers, at least on a Mac, appears to select...
IIRC recent desktop versions don't support this either.
Sorry, I remembered incorrectly. Images are disabled if you have markdown enabled, but that may change in the future.
If this error is sometimes triggered by bad revlog data, agreed that we need a better error to make it clearer. But I was under the impression the common case...
> The drawback of this approach is that the user will never know that something is wrong in their configaration. This is a valid point (and one I'd considered), but...
Things don't break until the user explicitly reoptimizes after an update, so I think the "user has no idea what happened" cases are going to be somewhat limited in scope....
Do you have a plan for how to solve this without the problem mentioned in the previous PR? If not, and you're more looking for something to get started with...