Damien Elmes

Results 241 comments of Damien Elmes

Hi Luc, My vision for the reviewer migration is to have the answer buttons handled as part of the reviewer page, rather than a separate webview. While we could potentially...

I'm hoping we can use an iframe to sandbox user-provided content and ensure it doesn't alter Anki's UI at all, or have access to our internal API. That is the...

That's promising! > Should this be with some sort of "reviewer-inner" endpoint for the iframe, or should it all be set from the reviewer as it is currently (in the...

Oh, and one thing I forgot to mention: you've used a writable for the POC, but for the real implementation, I think we'll probably want to directly manipulate the DOM...

> Something I've overlooked; as the iframe and bottom bar are still part of the same page, the zoom will now affect the bottom bar. Is this something that needs...

Sorry to keep you waiting Luc. I’ve struggled to find a big block of time where I could sit down and concentrate on this, and have been a bit overwhelmed...

Injecting `type here` into the deckbrowser HTML also triggers the issue, so it doesn't seem to be connected to our sveltekit/editor environment.

This has caused more disruption than I expected it to, and I think as a short-term solution we'll need to either increase the default limit and/or make it configurable.

If this is implemented, it wouldn't be in Qt, as we'd want it in the mobile clients too. But we need to discuss it first: https://github.com/ankitects/anki/pull/4088#issuecomment-2982709761

> Streaks are currently being considered whether they should be implemented into Anki, where dae seems to want to do away with traditional streaks in favor of a daily goal...