daboross

Results 163 comments of daboross

I've had this occur more often when I've introduced small syntax errors in my code and then tried to format than any other time. I'm unsure if that's just a...

`patch` was stabilized in October with 1.21.0 I guess? I ran into this with `replace`, which has existed since April 2016. I don't know which release stabilized it, but it...

If ergonomics for `Cow` are a blocker, do you think it could be fixed with a `new` method like this? ```rust pub fn new(name: U, author: T) where U: Into>,...

I don't think this wrong, it's just not fully general. I agree that it would be better if it were generic, but the current code won't cause any bugs, and...

Thank you for opening up this discussion! I'm using your crate, and really satisfied with the functionality. I'd have a bit of input in this, but what it has isn't...

Ah - that seems like a pretty reasonable implementation. Since `JsSerialize` takes `&self`, I think we might need to do more than just store an `&'a mut [T]` or use...

I've been reading up a bit more. While not everything makes since, I think if there's a raw pointer stored in the data structure it should be sound. Like you...

I think this is due to docs.rs not ever running build scripts. Perhaps we could remove the dependency on the build script for documentation?

Alright, that makes sense. Glad I didn't miss something obvious in the rustc documentation! I've opened https://github.com/rustwasm/wasm-bindgen/issues/1216 to continue the discussion and include wasm-bindgen.

Thanks for investigating this! I haven't investigated this fully, but might it be reasonable to port to no_std if we added a layer of abstraction between our read/write requirements &...