daboross

Results 163 comments of daboross

I believe this is more a bug in serde's enum handling interacting with the msgpack format than our processing. This is very similar to https://github.com/3Hren/msgpack-rust/issues/178 / https://github.com/serde-rs/serde/issues/1437. Specifically, when deserializing...

You can use the [`rmp_serde::encode::write`](https://docs.rs/rmp-serde/0.15.5/rmp_serde/encode/fn.write.html) function for this! `Vec` implements `std::io::Write` for exactly this purpose.

> which is usually not what is wanted Just speaking as another user, there are definitely use cases for loosely-validated deserialization. My use case isn't every use case of course,...

The earlier error might want to be a separate issue, as I can confirm it occurs reproducibly with regular minecraft clients, and a non-null Location. Here's the full error: ```...

Yeah, the plugin is using numerical IDs to set potions. The only reason currently to do it though is to restore stored items in chests, which were only stored by...

@momothereal Sorry, to be clear, what API replaces the raw data? PotionMeta seems to only support potions with getCustomPotions(), which only returns plugin-added potions, not ones that are placed on...

@momothereal Thanks, I must not have been looking at the most up to date docs. Should I close this issue now?

I can now fix my plugin to not cause this error, but if it is desirable that Glowstone produce a more descriptive error when this happens then the issue could...

@momothereal If it helps at all, I've now written a raw-byte-to-modern-API and vice-versa converter for my plugin. I'm sure it'd be easy to re-create, but it took me a while...

I believe [rust-analyzer](https://github.com/rust-analyzer/rust-analyzer) uses `additionalTextEdits` when completing an autocomplete suggestion which requires adding an additional import. If I have the following program: ```rust fn main() { println!("Hello, world!"); let x...