Dean Attali comments

Results 542 comments of


                                            Dean Attali

AddToThis replcaing the share buttons

Thanks for your input @ccorsi. While the AddToThis library is nice, I've come to the conclusion by now that it's not actually very necessary. It gets difficult to strike the...

Moving search to it's own file.

Thanks for the suggestion! I've been thinking about this for a while and while I do really agree with the idea, there's one problem that makes it difficult for me...

Moving search to it's own file.

@monksy ping :)

Moving search to it's own file.

Implemented in e6fc968cbdd592ed73ed49eb622cbf32ed67728c Thanks @ccorsi for your help

[BUG] Search JSON doesn't escape back slashes and breaks search

Fixed, thanks for the report

Allow some nodes to have fixed positions?

I 100% support having this feature built in. I also need to be able to enforce the position of nodes (not as an absolute (x,y), just in terms of order)

Importing from weird text formats

Thanks @noamross

Allow users to add a link to their snippet repo in the readme

When I first saw this package I thought "cool, I should share my snippets!" and immediately thought "but that's kind of a lame thing to tweet... and after the initial...

Look into upgrading to sweetalert2

The author of sweetalert2 confirmed that they will not fix these issues, and because this would constitute a non trivial regression, I do consider this a blocking issue. A custom...

Tooltip initialized with on="click" can only be closed by click on another data point

Until this gets impemented, if you want to have this behaviour in a shiny app you can easily achieve it with minimal javascript. Example: ``` library(shiny) library(ggvis) jscode % ggvis(~wt,...