Dean Attali comments

Results 542 comments of


                                            Dean Attali

pickerInput is slow to render large amounts of data

Just to confirm, I've tested this with the underlying javascript library (bootstrap-select v1.13.0) and it doesn't seem to be slow when using the javascript library directly ([example](http://jsfiddle.net/vau6qk1L/)). So this does...

Vertical centering of Type 7 spinner is not perfect

It looks like perhaps adding a css rule to the loader ``` top: px ``` would solve this. I'm not intimately familiar with all the parameters and usecases so perhaps...

`extendShinyjs(script = htmlDependency(...), functions = ...)` support

I haven't thought of this before, so it's not supported. The only reason it's not supported is because this function was written many years ago before I understood how `htmlDependency()`...

Allowing Spinner to keep height on redraw + delaying spinner show (avoid too many or too quick show/hide cycle)

Hi @rgriffogoes thanks a lot for the initiative! I haven't taken a close look yet, but I do notice that this PR is for two separate features. Could you please...

Allowing Spinner to keep height on redraw + delaying spinner show (avoid too many or too quick show/hide cycle)

@rgriffogoes Could you edit this PR to only contain the code relevant for "keep height on redraw" please?

Big blue LOADING.... with modules and appendTab/removeTab

Thanks for the report Arthur. Could you try to shorten the code to be as minimal as possible and use the least number of packages possible? It would be easier...

Big blue LOADING.... with modules and appendTab/removeTab

I'll have a look when I can find some time. But the code here is not really using proper reactivity and is doing things in a strange way, so perhaps...

Big blue LOADING.... with modules and appendTab/removeTab

@jernest1 could you provide a minimal reprex please

Big blue LOADING.... with modules and appendTab/removeTab

I don't think this has anything to do with modules as modules are not in this reprex at all. If I change your example to use `showTab`/`hideTab` instead of append/remove,...

Global loader

This isn't supported but would be a welcomed PR