Cliff Hansen
Cliff Hansen
Is the SMM predicted by this model meant to multiply the POA irradiance before accounting for reflections, or after reducing POA irradiance for reflections?
@RDaxini I have maintainer privilege so I can short-circuit the "PR to a PR" process: clone the submitter's repository, checkout the branch, edit and commit then push back to the...
If we're opening up v0.14 to other breaking changes: #2543 and the bug fix in #2612 although I think I should take over.
> Neither of these would have breaking changes today, would they? Both need deprecations first. Correct. I suppose they can wait, although it would be good to conclude #2543 and...
That docstring could use an example showing that getting to clearsky is a two-step procedure (`lookup_linke_turbidity` then `ineichen`) unless one brings their own turbidity data.
> Should a new argument be something like night_stow_theta to be explicit about what the value is? And would it be up to the user to pass np.nan if they...
> Something like `night_stow_tracker_theta` would be very descriptive Because the output rotation angle is `tracker_theta` - if I didn't know that I wouldn't know what "tracker_theta" meant in `night_stow_tracker_theta`. Too...
FTR, I am opposed to making the change from `sapm` to `fuentes` if we don't also add a default for the `fuentes` parameter `noct_installed`. We don't know what user code...
Credit to Larry Pratt at Groundwork for identifying the documentation issue.
@adriesse did you find [4] at a public source?