Cliff Hansen
Cliff Hansen
> @cwhanse Sir what can I do now ? Have you tried to run the examples? When I do, I get errors: Array is not imported, Array doesn't take `tilt`...
@kumaradityaapril please address the formatting issues identified by Flake8. There are two tests that use the `fuentes` model that now fail, almost certainly because the expected values were computed with...
I'm -1 on the new kwarg `use_eu_jrc`. The way I read the 2025 reference, the intent is to replace the older set of coefficients, to reflect "modern" modules. If we...
Any set of coefficients can be provided directly to the existing function, so kwargs like `version` aren't strictly necessary. But if we lean towards providing built-in parameters, as a convenience,...
@OmarBahamida any plan to move this forward? If not, I will do so. Thanks for starting this change.
@OmarBahamida we'd like to get this change into the next release. I took the liberty of restructuring the new kwarg and the test that looks up the coefficients.
@pvlib/pvlib-maintainer this is ready for reviews
Confirmed. It is some consolation that `latlon_to_xy` is a utility function that is not used within pvlib. Part of my resistance to using typing are docstrings like this one for...
> Re: the issue reported here, I'm wondering how it slipped through the tests. Test are all at low latitudes, so meter per degree longitude is nearly the same as...
Adding an illustration to the docstring of `pvlib.tracking.singleaxis` would help greatly to explain `axis_slope` and `cross_axis_slope`.