Cliff Hansen
Cliff Hansen
@markcampanelli I'm marking this change for v0.13.0. I think the `pytz` is likely in many user workflows, and dropping it entirely should have sufficient deprecation. Let's deprecate `pytz` in v0.12.0...
I'm in favor because I think that adopting the Array API standard makes pvlib functions more suitable for automatic differentiation.
@markcampanelli code structure looks fine to me. I am not sure why adding `iam.pchip` fits in the scope. Accepting a callable doesn't require pchip. It looks to me that pchip...
@markcampanelli a few in-flight comments: - `get_builtin_models` should be private. I'm not sure of the advantage of this function over a constant `dict. - I'm not sure why the code...
I would still make `get_builtin_model` private since it is hard to envisage its use outside the internal plumbing of pvlib. I'm sure it can find _some_ use, but at this...
@markcampanelli I think the scope of this PR is becoming too broad. Can you break the PR into several smaller bites?
Do we need to touch spectrum.mismatch.sapm to accomplish the end goal (allow any IAM model to be used with the Marion diffuse calculation)? If we don't need to change it,...
> I'm +1 to making the change As am I. In v0.14.
+1 for Option 4. I'm not opposed to the deprecation warning @ramaroesilva suggests but it may become onerous as these transposition functions are frequently used.
@yhkee0404 did you close this intentionally? If you aren't able to complete the PR, let us know and one of us could take it from here.