Cliff Hansen
Cliff Hansen
IMO `None` is the intended default and the docstring should be corrected.
Are we talking about a module to contain functions that take in `effective_irradiance` and `temp_cell` and output DC quantities and/or efficiency? That would be a logical next step in reducing...
> There could be more than those two inputs perhaps. I would see `pvarray` as a logical destination for all SAPM, PVWATTS, SDE module/array functions, focusing on the electrical side...
> Are we planning to eventually move some of the pvlib.pvsystem functionality to this new module? I would vote yes. What about moving PVArray? If I was looking for PVArray,...
I lean to agree with @kandersolar: leave the default `altitude` to be sea level in the solarposition functions.
@nicomt my vote is #1, let `Location` lookup altitude, but require it explicitly for the solar position functions.
Looks like a long-standing issue in the CEC data, where "Technology" has been "Thin film" for First Solar products from Series 4 and earlier since 2018 (archive [here](https://github.com/NREL/SAM/tree/patch/samples/CEC%20Module%20and%20Inverter%20Libraries/CEC%20Modules)). Maybe this...
Test failures are unrelated. Coverage decrease is related to importing statsmodels. I think I have addressed the maintainer's comments and concerns.
@OnairSandra when we've looked at similar reports, the root cause has been very low (e.g. 1e-9) values for effective irradiance. The solution has been to filter the effective irradiance before...
> I propose renaming tracker_shaded_fraction to shaded_fraction1d. +1 here > We should not forget the question about whether the math uses left- or right-handed rotations. I think we should strive...