pvlib-python icon indicating copy to clipboard operation
pvlib-python copied to clipboard
verified publisher icon pvlib

Add method to fit Huld model

Open cwhanse opened this issue 1 year ago • 4 comments

  • ~~[ ] Closes #xxxx~~
  • [X] I am familiar with the contributing guidelines
  • [X] Tests added
  • [X] Updates entries in docs/sphinx/source/reference for API changes.
  • [X] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [X] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • [x] Pull request is nearly complete and ready for detailed review.
  • [x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

cwhanse avatar Feb 23 '24 22:02 cwhanse

Test failures are unrelated. Coverage decrease is related to importing statsmodels.

I think I have addressed the maintainer's comments and concerns.

cwhanse avatar Apr 04 '24 20:04 cwhanse

We have one thing that is not fully resolved:

AFAIK Huld does not fully describe his fitting method, so a discussion may be needed to assess whether this requires a new publication. See https://github.com/pvlib/pvlib-python/discussions/1898.

I would suggest this PR join the queue, and perhaps more discussion will ensue. The upcoming PVPMC is also a great opportunity to discuss and perhaps develop a policy.

adriesse avatar Apr 19 '24 18:04 adriesse