Cliff Hansen
Cliff Hansen
> @kandersolar Could you help with the flake8 issue - I can't really tell what it is? Do you get the error if the csv files are read with pandas?
@bgpierc can you update the PR checklist?
@bgpierc https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/reference/iotools.rst
> > L is the thickness of the glass. It's an optional parameter of `iam.physical`, which is by default 2 mm (though most PV panels are actually 3.2 mm thick)....
@Jacc0027 the merge conflict doesn't show up here, so I think you need to merge the current `main` from pvlib to see what's going on. If you have `upstream` pointed...
@Jacc0027 that fixed the conflicts. Looks like some tests need corrections.
SAM 2022.11.21 is released with updated module and inverter libraries: https://github.com/NREL/SAM/tree/patch/deploy/libraries
Of the remaining items, Huld's DC model and perhaps the read ISD/ISH functions are worth considering. I wouldn't object to adding the Orgill and Hollands model. I would consider removing...
ISD is global data primarily for aviation. Sometimes (not common) there is an irradiance sensor, but mostly I've used it for air temperature and wind. https://www.ncei.noaa.gov/products/land-based-station/integrated-surface-database
I feel that we should have some kind of distributed celebration for closing _the_ oldest issue.