Cliff Hansen

> IMO array_like as defined by numpy is just fine I'll disagree on this point. Rarely do we design **and test** pvlib functions to accept any data type included in...

@Peque this is a good start. What would you think about `pvlib.storage.battery` (battery efficiency/state-of-charge models), with `pvlib.storage.dispatch` (functions that take in a Series of PV power and return some kind...

> So, the first step is to understand the state-of-the-art battery models and use cases. I will start with: There is a lot of battery-related content going into the next...

I think functions that represent automated controls, like ramp rate smoothing, could be considered within the scope of pvlib. An algorithm to optimize storage dispatch based on forecasts and TOU...

To me the value of wrapping pySAM is to facilitate use of SAM capabilities, and to bring those capabilities into (what we hope will be) a common interface for battery/storage...

Idea 1 - use keyword arguments maybe. V is most commonly used, I believe. Idea 2 - I'm ok with this as an optional argument. I'd default to log (natural...

I'm working on this issue and would appreciate any reactions to [this ](https://github.com/cwhanse/pvlib-python/commit/128d98487a7fc183311c8c9cc27e909517e67b7f) addition of a kwarg `voltage` in `pvsystem.singlediode`.

I thought the same but got stuck on the case when `ivcurve_pnts` is a singleton. What does `ivcurve_pnts = 5` mean? 5 points, or evaluate at `voltage = 5`? That's...

> I still think this function is a mess and should be broken up into smaller pieces. Maybe I was a bit quick to thumbs up. Is the mess in...

> That certainly doesn't help the situation, but my main complaint is that the function is supposed to do two different things: 1. calculate the 7 special points on the...