Cliff Hansen
Cliff Hansen
@bgpierc before we start polishing in earnest, could you clear up the stickler items? Makes it much easier to review. My first reactions are 1) that many of the utility...
> I think the ideal solution to retain commit authorship would have been to preserve the original commits themselves using git rather than copy/pasting their content and making new commits....
You raise a fair point. That has been the behavior since the original `ModelChain.singlediode` method in v0.4.0. I can't say exactly why; my guess is so that `ModelChain.result.dc.sum()` returns a...
@wholmgren what is your view of the benefit of this proposed change?
@steve-ransome looking forward to hosting this function. Have you thought about the function's signature? What are the inputs, what is output? I should look at your PVSC paper again, refresh...
> allows variables to be identified as "reference, measured or normalised" and also "uncorrected > or temperature corrected" (e.g. "nIsc_T") so need an idea if this is OK to use...
@pvlib/pvlib-maintainer @steve-ransome has sent me some refactored code for the module loss factor model (MLFM) that, with some attention to formatting and variable names, could be considered for pvlib-python. I'm...
> Is it close enough to have a PR? I think so. Python modules should be put into a new folder `pvlib.mlfm`.
@steve-ransome the next step is a PR so all maintainers can review. What problems did you have? Git has a learning kerb, for sure.
@steve-ransome my concern about creating the PR for you, is that someone will still need to use git to submit changes during the review. My workload is such that I...