Cliff Hansen

Results 492 comments of Cliff Hansen

This is probably a legacy of PVLib Matlab, where `alpha_isc` has units of 1/C, and `alpha_sc` has units of A/C. Let's hold off a PR for now. I think we...

> Is this something PVlib wants to incorporate? Yes, I think so. `horizon.py` is OK, I would like to think a bit more about how this module relates to existing...

@JPalakapillyKWH I'm not familiar with Google maps elevation data. What is the spatial resolution? Do the data represent the near-field or only the far-field horizon? Near-field accounts for trees, buildings,...

Ok, was just thinking how to describe the output of this module, as near-field or far-field shading. Horizon is usually interpreted as far field.

@JPalakapillyKWH super content for pvlib. I've read the reference and look through the code. Some high-level comments about modules and connecting with the rest of pvlib. would appreciate @wholmgren @mikofski...

> @cwhanse I don't think summing over the front of the panel will work I was not clear - I meant sum over the sky cells visible from the plane...

> Working my way through the docstrings and code. I am a little confused about the purpose of the "sample" functions - if a grid is being supplied as input,...

> Perhaps a good next step would be to add (or expand) Notes sections for the doc strings, where you explain the algorithms used, and give references to the sources...

@JPalakapillyKWH could you contact me privately at [email protected]? I have a few a questions I'd appreciate your input.

Most of this PR involved turning a [lat, long, elev] grid into [azimuth, elevation] for an observer location. I don't see any code to download the topographic data, but I...